[WIP] Implement Michalsky's solar position algorithm#2167
Draft
kandersolar wants to merge 3 commits intopvlib:mainfrom
Draft
[WIP] Implement Michalsky's solar position algorithm#2167kandersolar wants to merge 3 commits intopvlib:mainfrom
kandersolar wants to merge 3 commits intopvlib:mainfrom
Conversation
Member
|
Note, the solar position used by SOLPOS is the same as the Michalsky solar position algorithm. However, SOLPOS uses a different refraction correction algorithm than that given in the Michalsky paper. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.It may be useful to compare this implementation with SOLPOS (easily available in python via SolarUtils). SOLPOS is at least partially related to Michalsky, although I'm not yet sure if their outputs should be expected to be identical.
TODO: check whether the code works in the southern hemisphere (I saw it mentioned that the "original form" of the equations does not).